Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: region procedure service #137

Merged
merged 9 commits into from
Feb 2, 2024
Merged

feat: region procedure service #137

merged 9 commits into from
Feb 2, 2024

Conversation

killme2008
Copy link
Contributor

@killme2008 killme2008 commented Feb 2, 2024 •
edited
Loading

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

Changes for GreptimeTeam/greptimedb#3236

Main changes:

  1. Rename SubmitDdlTaskRequest/SubmitDdlTaskResponse to DdlTaskReques / DdlTaskResponse.
  2. Removed DdlTask RPC service, and added ProcedureService instead. Which adds new functions to query procedure state and migrate a table region.

Checklist

  • I have written the necessary comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

@killme2008 killme2008 changed the title Feature/region procedure service feat: region procedure service Feb 2, 2024
@killme2008 killme2008 requested review from WenyXu and v0y4g3r February 2, 2024 09:27
@killme2008 killme2008 mentioned this pull request Feb 2, 2024
Merged
7 tasks
fengjiachun
fengjiachun approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@fengjiachun fengjiachun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

v0y4g3r
v0y4g3r approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@v0y4g3r v0y4g3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v0y4g3r v0y4g3r merged commit 96f1f04 into GreptimeTeam:main Feb 2, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WenyXu WenyXu WenyXu approved these changes

@v0y4g3r v0y4g3r v0y4g3r approved these changes

@fengjiachun fengjiachun fengjiachun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@killme2008 @fengjiachun @v0y4g3r @WenyXu